This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
metrics: use tidb_cluster label get variable values #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label needs-cherry-pick-4.0 |
|
/lgtm |
|
/lgtm |
ti-srebot
approved these changes
Jan 27, 2021
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Jan 27, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #725 |
3pointer
pushed a commit
that referenced
this pull request
Jan 27, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Jiajin Zheng <zhengjiajin@pingcap.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The latest version of tidb-operator will use the instance name as the cluster label. The previous expression uses the cluster label got the value of the tidb_cluster variable. It will cause Grafana can not to display the data.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release Note